Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub workflow files template and README.md #2

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Add GitHub workflow files template and README.md #2

wants to merge 5 commits into from
+324 −0

Conversation

Structed
Copy link

Sorry for this unsolicited PR, but I figured it would be great to have a CI/CD workflow in the template for folks who want to save time on learning CI/CD and implementing their own automation!

It contains two workflows:

  1. main.yml - runs Unit/Integration tests using GUT
  2. release.yml - which:
  3. detects version changes via commit messages
  4. updates/creates CHANGELOG.md
  5. Creates a GitHub release and artifact
  6. Pushes the artifact to Godot AssetLib
  7. Pushes the artifact to Itch.io

@Calinou Calinou added the enhancement New feature or request label Jan 13, 2023
Calinou
Calinou reviewed Jan 13, 2023
View reviewed changes
.github/README.md Outdated Show resolved Hide resolved
@Structed Structed requested a review from paddy-exe January 14, 2023 20:57
paddy-exe
paddy-exe approved these changes Jan 14, 2023
View reviewed changes
Copy link

@paddy-exe paddy-exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good :D thank you!

@Structed Structed requested a review from Calinou January 14, 2023 21:04
paddy-exe
paddy-exe reviewed Jan 15, 2023
View reviewed changes
.github/README.md Outdated Show resolved Hide resolved
@Structed Structed requested review from paddy-exe and removed request for Calinou January 16, 2023 13:51
paddy-exe
paddy-exe suggested changes Jan 16, 2023
View reviewed changes
.github/README.md Show resolved Hide resolved
@Structed Structed marked this pull request as draft January 21, 2023 23:57
@Structed
Copy link
Author

Structed commented Jan 22, 2023 •
edited
Loading

  • Removed usage of PAT and using proper secrets definition in workflow
  • Fixed spelling and usage of environment variables
  • Added environment variable to avoid workflow-wide string-replacement for the addon name
  • Updated README.md to reflect changes
  • Fixed warnings

@Structed Structed marked this pull request as ready for review January 22, 2023 00:09
@Structed Structed requested a review from paddy-exe January 22, 2023 00:09
paddy-exe
paddy-exe approved these changes Jan 22, 2023
View reviewed changes
Copy link

@paddy-exe paddy-exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@Structed
Copy link
Author

Found an issue with not using a PAT. Because if I currently use only the GITHUB_TOKEN, the release prep commit will not trigger a re-run. Thus, the actual publish will never happen.

Discovered this as I updated my workflow files with these in godot-playfab.

@Structed Structed marked this pull request as draft January 25, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou left review comments

@paddy-exe paddy-exe paddy-exe approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Structed @Calinou @paddy-exe